Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudtrail: Replace GetOk with GetOkExists #2817

Merged
merged 2 commits into from
Feb 12, 2018
Merged

resource/aws_cloudtrail: Replace GetOk with GetOkExists #2817

merged 2 commits into from
Feb 12, 2018

Conversation

atsushi-ishibashi
Copy link
Contributor

Fixed: #2208

@radeksimko radeksimko changed the title r/cloudtrai: Replace GetOk with GetOkExists r/cloudtrail: Replace GetOk with GetOkExists Jan 2, 2018
@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jan 2, 2018
@atsushi-ishibashi atsushi-ishibashi mentioned this pull request Jan 6, 2018
Merged
@bflad bflad added the service/cloudtrail Issues and PRs that pertain to the cloudtrail service. label Jan 11, 2018
@radeksimko radeksimko changed the title r/cloudtrail: Replace GetOk with GetOkExists resource/aws_cloudtrail: Replace GetOk with GetOkExists Jan 16, 2018
radeksimko
radeksimko reviewed Feb 8, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks reasonable. Do you mind attaching a test which can verify the patch?

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Feb 8, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 10, 2018
@atsushi-ishibashi
Copy link
Contributor Author

@radeksimko Thank you!

TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudTrail_include_global_service_events -timeout 120m
=== RUN   TestAccAWSCloudTrail_include_global_service_events
--- PASS: TestAccAWSCloudTrail_include_global_service_events (87.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	87.151s

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 12, 2018
@radeksimko radeksimko merged commit caf0d81 into hashicorp:master Feb 12, 2018
@radeksimko radeksimko added this to the v1.10.0 milestone Feb 12, 2018
@bflad
Copy link
Contributor

bflad commented Feb 27, 2018

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

aws_cloudtrail does not respect initial include_global_service_events value of false
3 participants
@atsushi-ishibashi @bflad @radeksimko