Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arn attribute to aws_ssm_parameter resource and datasource #2273

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 14, 2017

Not provided by DescribeParameters API, so built manually. References:

Closes #2041

make testacc TESTARGS='-run=TestAccAwsSsmParameterDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAwsSsmParameterDataSource_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsSsmParameterDataSource_basic
--- PASS: TestAccAwsSsmParameterDataSource_basic (14.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.193s

make testacc TESTARGS='-run=TestAccAWSSSMParameter_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSSSMParameter_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSSMParameter_basic
--- PASS: TestAccAWSSSMParameter_basic (12.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.196s

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍 🚀

@radeksimko radeksimko merged commit 5cc0413 into hashicorp:master Nov 15, 2017
@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 15, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - ARN attribute exported for aws_ssm_parameter resource and data source
2 participants