fix incorrect Lambda GovCloud regexes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates two regexes that are used to validate and parse ARNs for aws_lambda_permission. The ARNs were not accurate when using GovCloud Lambdas. This resulted in failures during the read call after applying a resource.
Ninir
added
the
enhancement
radeksimko
force-pushed
the
fix/lambda_permission_govcloud
branch
from
0b78a2b
to
d5ea4d0
Compare
This corrects the region of the existing Lambda GovCloud tests and adds one more GovCloud test for the aws_lambda_permission resource.
radeksimko
force-pushed
the
fix/lambda_permission_govcloud
branch
from
d5ea4d0
to
e7e0c56
Compare
radeksimko
approved these changes
Jun 14, 2017
|
Ah, yes. The us-west-2 region is not a GovCloud region, so that ARN could never occur, though it can't hurt anything to test for other region formats there if they ever make one. Personally, I think the Regex is unnecessarily strict. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for hashicorp/terraform#14850.
This addresses several regexes used for matching Lambda ARNs to account for the extra section in the GovCloud region name. It also updates tests to match.