-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read property dns_servers for resource resource_aws_ec2_client_vpn_endpoint #11889
Conversation
…dpoint Currently, the provider cannot change the attribute `dns_servers` on the resource resource_aws_ec2_client_vpn_endpoint. This can be fixed by setting the attribute properly when refreshing state
Unsure why my Travis build failed on the
I can start digging in, but I'm not sure how my change could have caused this. Some help would be appreciated 🙏 |
@atareshawty 👋 Thanks for the heads up. Seems to be a TravisCI issue, due to no fault of yours. I restarted the failed job to see if that'll make it green. |
Great, thanks for doing that! I considered toggling my PR open/closed to get another build, but didn’t want to spam anyone 😀 Looks like Travis is good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix, @atareshawty, LGTM 🚀
Output from acceptance testing:
--- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (17.71s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (19.24s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (21.03s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (24.47s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (26.73s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (27.13s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1755.87s)
This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Currently, the provider cannot change the attribute
dns_servers
on the resourceresource_aws_ec2_client_vpn_endpoint
once the value has been set. This can be fixed by setting the attribute when refreshing stateCommunity Note
Release note for CHANGELOG:
Output from acceptance testing: