Read property dns_servers for resource resource_aws_ec2_client_vpn_endpoint

[atareshawty]

Currently, the provider cannot change the attribute dns_servers on the resource resource_aws_ec2_client_vpn_endpoint once the value has been set. This can be fixed by setting the attribute when refreshing state

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Update resource_aws_ec2_client_vpn_endpoint.dns_servers when refreshing state

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsEc2ClientVpnEndpoint_withDNSServers'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ClientVpnEndpoint_withDNSServers -timeout 120m
=== RUN   TestAccAwsEc2ClientVpnEndpoint_withDNSServers
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_withDNSServers
=== CONT  TestAccAwsEc2ClientVpnEndpoint_withDNSServers
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (34.31s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       36.043s

...

[atareshawty]

Unsure why my Travis build failed on the Dependencies step:

travis_setup_go

gimme: given '1.13.x' but no release for '1.13' found

gimme: given '1.13.x' but no release for '1.13' found

Failed to run gimme

The command "travis_setup_go" failed and exited with 86 during .

I can start digging in, but I'm not sure how my change could have caused this. Some help would be appreciated 🙏

[bflad]

@atareshawty 👋 Thanks for the heads up. Seems to be a TravisCI issue, due to no fault of yours. I restarted the failed job to see if that'll make it green.

[atareshawty]

@atareshawty 👋 Thanks for the heads up. Seems to be a TravisCI issue, due to no fault of yours. I restarted the failed job to see if that'll make it green.

Great, thanks for doing that! I considered toggling my PR open/closed to get another build, but didn’t want to spam anyone 😀 Looks like Travis is good now

[bflad]

Thanks for this fix, @atareshawty, LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (17.71s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (19.24s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (21.03s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (24.47s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (26.73s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (27.13s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1755.87s)

[ghost]

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!