Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_rds_global_database: Allow Aurora MySQL 5.7 as a Global Database Engine #11790

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

fishfacemcgee
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11453

Release note for CHANGELOG:

resource_aws_rds_global_database: allow `aurora-mysql` to be used for the engine

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRdsGlobalCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSRdsGlobalCluster_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSRdsGlobalCluster_basic
=== PAUSE TestAccAWSRdsGlobalCluster_basic
=== RUN   TestAccAWSRdsGlobalCluster_disappears
=== PAUSE TestAccAWSRdsGlobalCluster_disappears
=== RUN   TestAccAWSRdsGlobalCluster_DatabaseName
=== PAUSE TestAccAWSRdsGlobalCluster_DatabaseName
=== RUN   TestAccAWSRdsGlobalCluster_DeletionProtection
=== PAUSE TestAccAWSRdsGlobalCluster_DeletionProtection
=== RUN   TestAccAWSRdsGlobalCluster_Engine_Aurora
=== PAUSE TestAccAWSRdsGlobalCluster_Engine_Aurora
=== RUN   TestAccAWSRdsGlobalCluster_EngineVersion_Aurora
=== PAUSE TestAccAWSRdsGlobalCluster_EngineVersion_Aurora
=== RUN   TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL
=== PAUSE TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL
=== RUN   TestAccAWSRdsGlobalCluster_StorageEncrypted
=== PAUSE TestAccAWSRdsGlobalCluster_StorageEncrypted
=== CONT  TestAccAWSRdsGlobalCluster_basic
=== CONT  TestAccAWSRdsGlobalCluster_EngineVersion_Aurora
=== CONT  TestAccAWSRdsGlobalCluster_DeletionProtection
=== CONT  TestAccAWSRdsGlobalCluster_Engine_Aurora
=== CONT  TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL
=== CONT  TestAccAWSRdsGlobalCluster_StorageEncrypted
=== CONT  TestAccAWSRdsGlobalCluster_DatabaseName
=== CONT  TestAccAWSRdsGlobalCluster_disappears
--- PASS: TestAccAWSRdsGlobalCluster_disappears (14.57s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (17.83s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (17.91s)
--- PASS: TestAccAWSRdsGlobalCluster_basic (18.01s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (18.39s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (28.66s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (30.44s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (30.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.609s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.007s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.014s [no tests to run]

@fishfacemcgee fishfacemcgee requested a review from a team January 29, 2020 14:58
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 29, 2020
Copy link
Contributor

@bateller bateller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fishfacemcgee fishfacemcgee changed the title Allow Aurora MySQL 5.7 as a Global Database Engine resource/aws_rds_global_database: Allow Aurora MySQL 5.7 as a Global Database Engine Feb 4, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 10, 2020
@bflad bflad added this to the v2.49.0 milestone Feb 11, 2020
@bflad bflad self-assigned this Feb 11, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much, @fishfacemcgee 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRdsGlobalCluster_disappears (10.62s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (12.35s)
--- PASS: TestAccAWSRdsGlobalCluster_basic (12.70s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (13.07s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (13.34s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (19.64s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (19.81s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (19.86s)

@bflad bflad merged commit 8128181 into hashicorp:master Feb 11, 2020
bflad added a commit that referenced this pull request Feb 11, 2020
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS RDS Aurora Global Cluster support for MySQL 5.7 (Aurora 2.x)
3 participants