Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_api_gateway_usage_plan_key: Support resource import #11439

Merged
merged 6 commits into from
Jan 6, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #558

Release note for CHANGELOG:

resource/aws_api_gateway_usage_plan_key: Support resource import 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayUsagePlanKey_'
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (163.66s)
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_disappears (87.32s)
...

@DrFaust92 DrFaust92 requested a review from a team December 30, 2019 16:33
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 30, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 4, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @DrFaust92 -- the implementation here is off to a good start. 😄 Rather than burdening operators to provide the key type during import, it looks like we should be properly performing drift detection of the attribute by setting it in the Terraform state in the Read function. This will remove the import ID requirement. Please reach out if you have any questions or do not have time to implement the feedback.

aws/resource_aws_api_gateway_usage_plan_key.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 4, 2020
@bflad bflad self-assigned this Jan 4, 2020
@DrFaust92
Copy link
Collaborator Author

--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (188.10s)
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_disappears (97.07s)

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 4, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DrFaust92! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayUsagePlanKey_disappears (21.37s)
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (106.97s)

@bflad bflad added this to the v2.44.0 milestone Jan 6, 2020
@bflad bflad merged commit 2be1b48 into hashicorp:master Jan 6, 2020
bflad added a commit that referenced this pull request Jan 6, 2020
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
@DrFaust92 DrFaust92 deleted the apigw-deployment-import branch March 27, 2020 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants