Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ebs_snapshot_copy - refactor to use keyvaluetags #10936

Merged
merged 5 commits into from
Nov 21, 2019
Merged

r/aws_ebs_snapshot_copy - refactor to use keyvaluetags #10936

merged 5 commits into from
Nov 21, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688 & Closes #10924

Release note for CHANGELOG:

- resource/resource_aws_ebs_snapshot_copy: tags support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEbsSnapshotCopy_'

=== RUN   TestAccAWSEbsSnapshotCopy_basic
=== PAUSE TestAccAWSEbsSnapshotCopy_basic
=== CONT  TestAccAWSEbsSnapshotCopy_basic
--- PASS: TestAccAWSEbsSnapshotCopy_basic (126.24s)
=== RUN   TestAccAWSEbsSnapshotCopy_tags
=== PAUSE TestAccAWSEbsSnapshotCopy_tags
=== CONT  TestAccAWSEbsSnapshotCopy_tags
--- PASS: TestAccAWSEbsSnapshotCopy_tags (282.77s)
=== RUN   TestAccAWSEbsSnapshotCopy_withDescription
=== PAUSE TestAccAWSEbsSnapshotCopy_withDescription
=== CONT  TestAccAWSEbsSnapshotCopy_withDescription
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (96.15s)
=== RUN   TestAccAWSEbsSnapshotCopy_withRegions
=== PAUSE TestAccAWSEbsSnapshotCopy_withRegions
=== CONT  TestAccAWSEbsSnapshotCopy_withRegions
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (97.88s)
=== RUN   TestAccAWSEbsSnapshotCopy_withKms
=== PAUSE TestAccAWSEbsSnapshotCopy_withKms
=== CONT  TestAccAWSEbsSnapshotCopy_withKms
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (168.83s)
=== RUN   TestAccAWSEbsSnapshotCopy_disappears
=== PAUSE TestAccAWSEbsSnapshotCopy_disappears
=== CONT  TestAccAWSEbsSnapshotCopy_disappears
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (138.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	432.651s

...

This might be considered a breaking change

@DrFaust92 DrFaust92 requested a review from a team November 19, 2019 19:36
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2019
@DrFaust92 DrFaust92 changed the title R ebs snapshot copy keyvaluetags r/aws_ebs_snapshot_copy - refactor to use keyvaluetags Nov 19, 2019
@bflad bflad self-assigned this Nov 21, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2019
@bflad bflad added this to the v2.40.0 milestone Nov 21, 2019
bflad
bflad approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEbsSnapshotCopy_disappears (52.36s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (52.56s)
--- PASS: TestAccAWSEbsSnapshotCopy_basic (52.77s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (61.52s)
--- PASS: TestAccAWSEbsSnapshotCopy_tags (63.07s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (84.60s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEbsSnapshotCopy_basic (46.64s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (47.08s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (47.11s)
--- PASS: TestAccAWSEbsSnapshotCopy_tags (50.17s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (64.87s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (67.50s)

@bflad bflad merged commit c012087 into hashicorp:master Nov 21, 2019
bflad added a commit that referenced this pull request Nov 21, 2019
@bflad
Update CHANGELOG for #10936
d13e4f9
pixelpogo pushed a commit to babbel/terraform-provider-aws that referenced this pull request Nov 22, 2019
@DrFaust92 @pixelpogo
resource/aws_ebs_snapshot_copy: Support tagging-on-create and in-plac…
e2fe837 
…e `tags` updates (hashicorp#10936)

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (52.36s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (52.56s)
--- PASS: TestAccAWSEbsSnapshotCopy_basic (52.77s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (61.52s)
--- PASS: TestAccAWSEbsSnapshotCopy_tags (63.07s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (84.60s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSEbsSnapshotCopy_basic (46.64s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (47.08s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (47.11s)
--- PASS: TestAccAWSEbsSnapshotCopy_tags (50.17s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (64.87s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (67.50s)
```
pixelpogo pushed a commit to babbel/terraform-provider-aws that referenced this pull request Nov 22, 2019
@bflad @pixelpogo
Update CHANGELOG for hashicorp#10936
f4d6292
@ghost
Copy link

ghost commented Nov 27, 2019

This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r-ebs-snapshot-copy-keyvaluetags branch December 24, 2019 17:11
@ghost
Copy link

ghost commented Dec 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.40.0
Development

Successfully merging this pull request may close these issues.

EBS snapshot: Add tags while copying
2 participants
@DrFaust92 @bflad