Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_cloudwatch_log_group: add attributes #10755

Merged
merged 7 commits into from
Jan 17, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

- data/data_source_aws_cloudwatch_log_group: Add `tags`, `kms_key_id`, `retention_in_days` attributes.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudwatchLogGroupDataSource_'

=== RUN   TestAccAWSCloudwatchLogGroupDataSource_basic
=== PAUSE TestAccAWSCloudwatchLogGroupDataSource_basic
=== CONT  TestAccAWSCloudwatchLogGroupDataSource_basic
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_basic (206.28s)
=== RUN   TestAccAWSCloudwatchLogGroupDataSource_tags
=== PAUSE TestAccAWSCloudwatchLogGroupDataSource_tags
=== CONT  TestAccAWSCloudwatchLogGroupDataSource_tags
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_tags (115.08s)
=== RUN   TestAccAWSCloudwatchLogGroupDataSource_kms
=== PAUSE TestAccAWSCloudwatchLogGroupDataSource_kms
=== CONT  TestAccAWSCloudwatchLogGroupDataSource_kms
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_kms (206.24s)
=== RUN   TestAccAWSCloudwatchLogGroupDataSource_retention
=== PAUSE TestAccAWSCloudwatchLogGroupDataSource_retention
=== CONT  TestAccAWSCloudwatchLogGroupDataSource_retention
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_retention (104.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	653.803s

...

@DrFaust92 DrFaust92 requested a review from a team November 5, 2019 17:15
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cloudwatchlogs tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 5, 2019
@DrFaust92 DrFaust92 changed the title d/aws_cloudwatch_log_group: add attributes + refactor keyvalue d/aws_cloudwatch_log_group: add attributes Nov 5, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 17, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCloudwatchLogGroupDataSource_retention (8.77s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_basic (9.08s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_tags (9.14s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_kms (28.03s)

@bflad bflad merged commit 6de6b8f into hashicorp:master Jan 17, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 17, 2020
bflad added a commit that referenced this pull request Jan 17, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the cloudwatchlogs-data-keyvaluetags branch January 24, 2020 16:27
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants