Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reserved ip submodule #415

Merged
merged 28 commits into from
Nov 21, 2024
Merged

feat: add reserved ip submodule #415

merged 28 commits into from
Nov 21, 2024

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Oct 9, 2023 •
edited
Loading

Description

#395

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Provides a way to create a reserved ip independently from the VPE creation. Ensures that the consumer has got full control on the reserved ip's being attached. This is used in the scenario where a consumer wants to have the same ip for a given VPE type across VPC's.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Oct 9, 2023
@jor2 jor2 marked this pull request as ready for review October 9, 2023 16:59
@jor2
Copy link
Member Author

jor2 commented Oct 10, 2023

/run pipeline

5 similar comments
@vburckhardt
Copy link
Member

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 16, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 16, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 18, 2023

/run pipeline

@vburckhardt
Copy link
Member

/run pipeline

vburckhardt
vburckhardt requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jordan, a couple of comments inline. Also the top level readme should have one or 2 sentences around the reserved ip feature and why it exists.

modules/reserved-ips/main.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
examples/reserved-ips/README.md Show resolved Hide resolved
@jor2
Copy link
Member Author

jor2 commented Nov 2, 2023

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Nov 7, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 8, 2023

blocked by #435

@shemau
Copy link
Contributor

shemau commented Nov 9, 2023

I have raised #437 as a possible solution to #435. It would require small changes to this PR.

@jor2
Copy link
Member Author

jor2 commented Nov 15, 2023

/run pipeline

8 similar comments
@jor2
Copy link
Member Author

jor2 commented Nov 22, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 22, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 22, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 22, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 23, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 23, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 27, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 28, 2023

/run pipeline

shemau
shemau requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an upgrade test in other_test.go. These tests are run during the continuous test, however, in that context what is the upgrade?

modules/reserved-ips/README.md Outdated Show resolved Hide resolved
modules/reserved-ips/README.md Outdated Show resolved Hide resolved
modules/reserved-ips/README.md Outdated Show resolved Hide resolved
@jor2
Copy link
Member Author

jor2 commented Dec 5, 2023

/run pipeline

2 similar comments
@jor2
Copy link
Member Author

jor2 commented Dec 5, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Dec 14, 2023

/run pipeline

@jor2 jor2 requested review from vburckhardt and shemau December 15, 2023 14:59
@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

@jor2 jor2 requested a review from shemau September 3, 2024 13:19
@jor2
Copy link
Member Author

jor2 commented Oct 7, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 7, 2024

/run pipeline

@jor2 jor2 requested a review from ocofaigh October 7, 2024 12:33
@jor2
Copy link
Member Author

jor2 commented Oct 8, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 14, 2024

/run pipeline

2 similar comments
@jor2
Copy link
Member Author

jor2 commented Oct 15, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 16, 2024

/run pipeline

toddgiguere
toddgiguere requested changes Oct 16, 2024
View reviewed changes
modules/reserved-ips/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
@jor2
Copy link
Member Author

jor2 commented Oct 22, 2024

/run pipeline

@jor2 jor2 requested a review from toddgiguere October 22, 2024 22:12
@jor2
Copy link
Member Author

jor2 commented Nov 19, 2024

/run pipeline

@toddgiguere toddgiguere dismissed vburckhardt’s stale review November 21, 2024 15:42

very old review, many updates since then, new set of reviewers

@toddgiguere toddgiguere merged commit a32c967 into main Nov 21, 2024
2 checks passed
@toddgiguere toddgiguere deleted the pg-module branch November 21, 2024 15:56
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddgiguere toddgiguere toddgiguere approved these changes

@vburckhardt vburckhardt Awaiting requested review from vburckhardt

@shemau shemau Awaiting requested review from shemau shemau is a code owner

@ocofaigh ocofaigh Awaiting requested review from ocofaigh

Assignees

@jor2 jor2

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jor2 @vburckhardt @shemau @ocofaigh @terraform-ibm-modules-ops @toddgiguere