Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add admission controller #189

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ctolon22
Copy link
Contributor

Description

Add support for installing SCC-WP Admission Controller:

  • Webhook
  • KSPM admission controller

It's disabled by default

It requires adding Sysdig API Token when used.

Release required?

  • No release
  • Patch release (x.x.X)
  • [ x] Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - is there a reason why we would not enable the admission controller by default?

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@ctolon22
Copy link
Contributor Author

Left some comments - is there a reason why we would not enable the admission controller by default?

As it requires the API Token, I would like to reduce what customers need to introduce and only use it if they actually want it.
When moving to cluster-shield / host-shield later this year, we'll enable it by default as the Token requirement will not be necessary anymore

Fixing now the rest of comments

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comments

variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

@ctolon22 Test failed with this:

│ Error: Missing required argument
│ 
│   with module.scc_wp_agent.helm_release.scc_wp_agent,
│   on ../../main.tf line 36, in resource "helm_release" "scc_wp_agent":
│   36: resource "helm_release" "scc_wp_agent" {
│ 
│ The argument "set.40.value" is required, but no definition was found.
╵}

@ocofaigh
Copy link
Member

@ctolon22 we probably also want to update the example that the test runs to actually deploy the admission controller so that we test it in PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants