-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add admission controller #189
base: main
Are you sure you want to change the base?
Feat: Add admission controller #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments - is there a reason why we would not enable the admission controller by default?
As it requires the API Token, I would like to reduce what customers need to introduce and only use it if they actually want it. Fixing now the rest of comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See latest comments
/run pipeline |
@ctolon22 Test failed with this:
|
@ctolon22 we probably also want to update the example that the test runs to actually deploy the admission controller so that we test it in PRs |
Description
Add support for installing SCC-WP Admission Controller:
It's disabled by default
It requires adding Sysdig API Token when used.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers