Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OCP default to 4.16 #922

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Update OCP default to 4.16 #922

merged 2 commits into from
Nov 29, 2024

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Nov 29, 2024

Description

Even though the default was set to 4.16 in variables.tf - it was not updated in ibm_catalog.json meaning the tile was never updated. I am removing the default value from the catalog manifest to prevent this from happening again, which means it will always use the default value in the terraform code.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh changed the title Even th Update OCP default to 4.16 Nov 29, 2024
@ocofaigh
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit a93f177 into main Nov 29, 2024
2 checks passed
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch November 29, 2024 21:25
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants