legacy network interface /VNI bug

[surajsbharadwaj]

When upgrading from a previous version, VSIs may be destroyed and recreated. To prevent re-creation or to use the legacy network interface, set var.use_legacy_network_interface to true

But why does it error out for new deployments?

Our pipeline failed during terraform plan:
https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/actions/runs/11891563625/job/33132802142#step:6:659
https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/actions/runs/11891563625/job/33132802142#step:6:2380

Preset used: https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/blob/main/modules/powervs-vpc-landing-zone/presets/slz-preset.json.tftpl

Module used:

module "landing_zone" {
  source    = "terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module"
  version   = "6.2.2"
  providers = { ibm = ibm.ibm-is }

  ssh_public_key       = var.ssh_public_key
  region               = lookup(local.ibm_powervs_zone_cloud_region_map, var.powervs_zone, null)
  prefix               = var.prefix
  override_json_string = local.override_json_string
}

Affected modules

Terraform CLI and Terraform provider versions

• Terraform version:
• Provider version:

Terraform output

Debug output

Expected behavior

Actual behavior

Steps to reproduce (including links and screen captures)

1. Run terraform apply

Anything else

---

By submitting this issue, you agree to follow our Code of Conduct

[Aashiq-J]

Fix added in this PR: #661