Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vpc data lookup #798

Merged
merged 13 commits into from
Jun 6, 2024
Merged

fix: vpc data lookup #798

merged 13 commits into from
Jun 6, 2024

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Jun 6, 2024

Description

fix vpc data lookup not known at apply causing resources to be recreated in slz.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

fix vpc data lookup not known at apply causing resources to be recreated in slz.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jun 6, 2024
@jor2
Copy link
Member Author

jor2 commented Jun 6, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jun 6, 2024

/run pipeline

@jor2 jor2 requested a review from ocofaigh June 6, 2024 12:47
@jor2
Copy link
Member Author

jor2 commented Jun 6, 2024

/run pipeline

@ocofaigh ocofaigh merged commit fe27e6f into main Jun 6, 2024
2 checks passed
@ocofaigh ocofaigh deleted the fix branch June 6, 2024 15:11
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.18.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants