Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manual resolver and example #663

Merged
merged 14 commits into from
Nov 10, 2023
Merged

feat: manual resolver and example #663

merged 14 commits into from
Nov 10, 2023

Conversation

rajatagarwal-ibm
Copy link
Member

@rajatagarwal-ibm rajatagarwal-ibm commented Nov 9, 2023

Description

  • Option to create a manual resolver
  • Added validations and flags
  • Example
  • Tests

fixes #652

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@rajatagarwal-ibm
Copy link
Member Author

rajatagarwal-ibm commented Nov 9, 2023

@vburckhardt FYI

when I try to spin up "delegated" service - it says only system and manual are allowed. See the message below:

│         "errors": [
│             {
│                 "code": "validation_failed_oneof",
│                 "message": "Expected only one oneOf fields to be set: got 0",
│                 "target": {
│                     "name": "VpcdnsResolverPrototype",
│                     "type": "field"
│                 }
│             },
│             {
│                 "code": "validation_failed_enum",
│                 "message": "VpcdnsResolverTypeManualPrototype is invalid: Validation Failure: Expected [\"manual\"]",
│                 "target": {
│                     "name": "VpcdnsResolverTypeManualPrototype.VpcdnsResolverTypeManualPrototypeType",
│                     "type": "field",
│                     "value": "\"delegated\""
│                 }
│             },
│             {
│                 "code": "validation_failed_enum",
│                 "message": "VpcdnsResolverTypeSystemPrototype is invalid: Validation Failure: Expected [\"system\"]",
│                 "target": {
│                     "name": "VpcdnsResolverTypeSystemPrototype.VpcdnsResolverTypeSystemPrototypeType",
│                     "type": "field",
│                     "value": "\"delegated\""
│                 }
│             }
│         ],
│         "trace": "ee4a6b58-4f91-4274-a3cf-1c23baa37a11"
│     }
│ }
│  
│ 
│   with module.spoke_vpc.ibm_is_vpc.vpc,
│   on ../../main.tf line 29, in resource "ibm_is_vpc" "vpc":
│   29: resource "ibm_is_vpc" "vpc" {
│ 
╵

It also says that "dns" is invitation-only service. Not sure if that might be the reason behind not supporting "delegated" service yet (docs: https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_vpc#dns)
image

@rajatagarwal-ibm rajatagarwal-ibm changed the title feat: manual resolver feat: manual resolver and example Nov 9, 2023
@rajatagarwal-ibm
Copy link
Member Author

Ran both pr_tests and other_tests locally and they passed successfully.

@vburckhardt
Copy link
Member

/run pipeline

1 similar comment
@vburckhardt
Copy link
Member

/run pipeline

@vburckhardt vburckhardt self-requested a review November 10, 2023 16:30
@vburckhardt vburckhardt merged commit 13b7d08 into main Nov 10, 2023
@vburckhardt vburckhardt deleted the manual-resolver branch November 10, 2023 16:42
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of dns attributes to the vpc resource
3 participants