-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extend the vpc output data #641
Conversation
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, so I am approving. The one question, why expose a limited (and arbitrary?) set of VPC properties, as opposed to just exposing ibm_is_vpc.vpc and providing the full information to the module consumer?
/run pipeline |
@shemau , I'm not sure why it wasn't done before. I thought there would be some sensitive information in the output so added only limited values. Now I checked there are no sensitive values so exposing the output of ibm_is_vpc.vpc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 7.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Need few extra information of vpc in the slz to create a output in SLZ. As per this Issue
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Adding a detailed vpc output.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers