Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend the vpc output data #641

Merged
merged 4 commits into from
Oct 13, 2023
Merged

fix: extend the vpc output data #641

merged 4 commits into from
Oct 13, 2023

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Oct 13, 2023

Description

Need few extra information of vpc in the slz to create a output in SLZ. As per this Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Adding a detailed vpc output.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J marked this pull request as ready for review October 13, 2023 10:49
shemau
shemau previously approved these changes Oct 13, 2023
Copy link

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, so I am approving. The one question, why expose a limited (and arbitrary?) set of VPC properties, as opposed to just exposing ibm_is_vpc.vpc and providing the full information to the module consumer?

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

@shemau , I'm not sure why it wasn't done before. I thought there would be some sensitive information in the output so added only limited values. Now I checked there are no sensitive values so exposing the output of ibm_is_vpc.vpc

Copy link

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit 33d2c73 into main Oct 13, 2023
@ocofaigh ocofaigh deleted the vpc-output branch October 13, 2023 13:46
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants