Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added basic example #640

Merged
merged 9 commits into from
Oct 13, 2023
Merged

test: added basic example #640

merged 9 commits into from
Oct 13, 2023

Conversation

rajatagarwal-ibm
Copy link
Member

Description

adds a basic example

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

examples/basic/main.tf Show resolved Hide resolved
examples/basic/main.tf Outdated Show resolved Hide resolved
@rajatagarwal-ibm
Copy link
Member Author

Ran successful test locally
image

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member

Error: [ERROR] Error creating resource group: instance.name does not meet maximum length of 40 with response code - Do we have a bug somewhere?

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

Error: [ERROR] Error creating resource group: instance.name does not meet maximum length of 40 with response code - Do we have a bug somewhere?

Reduced the name length in "no-prefix" test.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 5ce7cee into main Oct 13, 2023
@ocofaigh ocofaigh deleted the basic-example branch October 13, 2023 14:56
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants