Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolving duplicate outbound address names for acl rules #506

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

imprateeksh
Copy link
Member

Description

This is to fix the issue seen as duplicate names for acl rule. Refer issue-4501

Types of changes in this PR

No release required

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other changes that don't affect Terraform code

Release required

  • Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
  • New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
  • Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)
Release notes content
  • Resolved duplicate ACL rule name seen for outbound rules.

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Merge by using "Squash and merge".

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.

    The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

@imprateeksh imprateeksh self-assigned this Apr 17, 2023
@imprateeksh imprateeksh added the bug 🐞 Something isn't working label Apr 17, 2023
@imprateeksh imprateeksh marked this pull request as ready for review April 17, 2023 14:15
@jojustin jojustin merged commit a6aed91 into main Apr 18, 2023
@jojustin jojustin deleted the fix-outbound-acl-name branch April 18, 2023 08:31
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 6.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants