refactor: removing unused variable

[imprateeksh]

Description

Enhancement: To remove the unused optional variable network_connections
Refer issue 485 for details.

Types of changes in this PR

No release required

• Examples or tests (addition or updates of examples or tests)
• Documentation update
• CI-related update (pipeline, etc.)
• [] Other changes that don't affect Terraform code

Release required

• Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
• New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
• Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content

fix: The network_connections option has been removed from the network_acls variable as it was not being used in the code

BREAKING CHANGE: If you are upgrading to this version, and you have the network_connections option in the network_acls variable, it should be removed.

---

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

• Merge by using "Squash and merge".

• Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.

  The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

[imprateeksh]

This passed successfully but once integrated latest main changes today, can see some failure in the upgrade test.
It appears that network ACL rule already exists.

Re-running first to see if this error still occurs.

[imprateeksh]

Validation succeeded after re-running the jobs.

[ocofaigh]

@imprateeksh why have you ticked the boxes for Documentation update and Other changes that don't affect Terraform code ? This is a change to a terraform variable. Infact its probably a breaking change which will warrant a major version update. Don't you agree?

[SirSpidey]

small suggestion

[imprateeksh]

@imprateeksh why have you ticked the boxes for Documentation update and Other changes that don't affect Terraform code ? This is a change to a terraform variable. Infact its probably a breaking change which will warrant a major version update. Don't you agree?

HI @ocofaigh - Documentation update was chosen as there was change in the description of the variable. Indeed it is breaking change and Other changes that don't affect Terraform code is not applicable here.
I have made these corrections. Thank you for pointing out.

[terraform-ibm-modules-ops]

🎉 This PR is included in version 6.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀