fix: removed the opening of 0.0.0.0/0 in the default value for network acls rules #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocofaigh
reviewed
Mar 9, 2023
main.tf
Outdated
| type = 1 | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think we want this in the root level module? There is a variable called network_acls that allows the consumers to pass in their ACL config
added 2 commits
March 9, 2023 12:59
ocofaigh
reviewed
Mar 9, 2023
cra-tf-validate-ignore-goals.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "scc_goals": [] | |||
There was a problem hiding this comment.
you will need to ignore all of the COS goals (not relevant to the root module here, just the example)
As for the VPC ones, we may need to review each one as a team to decide what to do
…rm-ibm-landing-zone-vpc into enable-cra
ocofaigh
changed the title
ocofaigh
approved these changes
Mar 15, 2023
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
9 tasks
gmendel
pushed a commit
to gmendel/landing-zone-vpc
that referenced
this pull request
Mar 29, 2023
…k acls rules (terraform-ibm-modules#424) BREAKING CHANGE: If you were consuming the module using the default value for var.network_acls and upgraded to this version, the `allow-all-443-inbound` and `allow-all-443-outbound` ACL rules will be removed since opening 0.0.0.0/0 is not FsCloud compliant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this text with a summary of the changes in this PR. Include why the changes are needed and context about the changes. List required dependencies. If there is a Git issue for the change, please link to it.
Types of changes in this PR
https://github.ibm.com/goldeneye/issues/issues/4122
No release required
Release required
x.x.X): Change that fixes an issue and is compatible with earlier versions)x.X.x): Change that adds functionality and is compatible with earlier versions)X.x.x): Change that is likely incompatible with previous versions)Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.
Checklist for reviewers
Merge actions for mergers
Merge by using "Squash and merge".
Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).