Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modified to use the latest terraform version #159

Merged
merged 3 commits into from
Jan 26, 2023
Merged

fix: modified to use the latest terraform version #159

merged 3 commits into from
Jan 26, 2023

Conversation

imprateeksh
Copy link
Member

Description

  • Optional attributes are removed in order to support latest Terraform version i.e.
    experiments = [module_variable_optional_attrs]
  • Terraform version is updated i.e.required_version = ">= 1.3.0"

Check the relevant boxes:

  • Bug fix (nonbreaking change that fixes an issue)
  • New feature (nonbreaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI related update (pipeline, etc.)

Checklist

  • If relevant, a test for the change has been added or updated as part of this PR.
  • If relevant, documentation for the change has been added or updated as part of this PR.

Merge

  • Merge using "Squash and merge".
  • Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

@imprateeksh imprateeksh requested a review from ocofaigh November 10, 2022 05:54
@imprateeksh imprateeksh self-assigned this Nov 10, 2022
ocofaigh
ocofaigh previously approved these changes Nov 10, 2022
View reviewed changes
@ocofaigh
ci: bump git submodule
9c43c72 
BREAKING CHANGE: module is no longer supported on terraform versions lower than 1.3
@ocofaigh
ci: rebase
8817b8b
@ocofaigh ocofaigh marked this pull request as ready for review January 26, 2023 09:45
@ocofaigh ocofaigh merged commit 5439a61 into main Jan 26, 2023
@ocofaigh ocofaigh deleted the 2858-tf-version-update branch January 26, 2023 09:51
gmendel pushed a commit to gmendel/landing-zone-vpc that referenced this pull request Mar 29, 2023
@imprateeksh @gmendel
feat: add support for terraform >= 1.3 (terraform-ibm-modules#159)
1a09262 
BREAKING CHANGE: module is no longer supported on terraform versions lower than 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

Assignees

@imprateeksh imprateeksh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imprateeksh @ocofaigh