Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network acl fix for source port max #122

Merged
merged 3 commits into from
Oct 6, 2022
Merged

fix: network acl fix for source port max #122

merged 3 commits into from
Oct 6, 2022

Conversation

argeiger
Copy link
Contributor

@argeiger argeiger commented Oct 4, 2022

Description

Fix for the network acl source port max

Check the relevant boxes:

  • Bug fix (nonbreaking change that fixes an issue)
  • New feature (nonbreaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI related update (pipeline, etc.)

Checklist

  • If relevant, a test for the change has been added or updated as part of this PR.
  • If relevant, documentation for the change has been added or updated as part of this PR.

Merge

  • Merge using "Squash and merge".
  • Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

ocofaigh
ocofaigh previously approved these changes Oct 4, 2022
@ocofaigh
Copy link
Member

ocofaigh commented Oct 4, 2022

@argeiger The upgrade test is failing because it has identified an update:

Messages:   	Resource(s) identified to be updated Name: network_acl Address: module.slz_vpc.ibm_is_network_acl.network_acl["vpc-acl"] Actions: [update]

I guess this is expected due to the nature of the change here. If you agree, by committing a new commit which includes the text SKIP UPGRADE TEST in it, it will skip the upgrade test.

@ocofaigh
Copy link
Member

ocofaigh commented Oct 6, 2022

Pushed a commit with the text SKIP UPGRADE TEST in order to skip the upgrade test as the change that failed the upgrade test is expected here.

@ocofaigh ocofaigh merged commit 002ea98 into main Oct 6, 2022
@ocofaigh ocofaigh deleted the fix-acl-rule branch October 6, 2022 14:41
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

gmendel pushed a commit to gmendel/landing-zone-vpc that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants