-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include log for each database name in export workflow #407
Merged
g-awmalik
merged 15 commits into
terraform-google-modules:master
from
adeusmondo:feat/log_database_names_export
May 1, 2023
Merged
feat: include log for each database name in export workflow #407
g-awmalik
merged 15 commits into
terraform-google-modules:master
from
adeusmondo:feat/log_database_names_export
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-awmalik
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. A few minor nits.
Oh, sorry for the delay and thanks for the code review |
…smondo/terraform-google-sql-db into feat/log_database_names_export
@adeusmondo |
g-awmalik
approved these changes
Feb 10, 2023
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add log, because sometimes i need to show how many time each database takes to be exported