Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include log for each database name in export workflow #407

Conversation

adeusmondo
Copy link

This PR is to add log, because sometimes i need to show how many time each database takes to be exported

@adeusmondo adeusmondo requested a review from a team as a code owner January 12, 2023 21:55
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A few minor nits.

modules/backup/variables.tf Outdated Show resolved Hide resolved
modules/backup/main.tf Outdated Show resolved Hide resolved
@adeusmondo
Copy link
Author

Thanks for the PR. A few minor nits.

Oh, sorry for the delay and thanks for the code review

@comment-bot-dev
Copy link

@adeusmondo
Thanks for the PR! 🚀
✅ Lint checks have passed.

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit e638a24 into terraform-google-modules:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants