Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix output refers to sensitive values #334

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix output refers to sensitive values #334

merged 2 commits into from
Aug 9, 2022

Conversation

6aKa
Copy link
Contributor

@6aKa 6aKa commented Aug 5, 2022

Fix for issue #319

@google-cla
Copy link

google-cla bot commented Aug 5, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @6aKa. Please sign the CLA.
Also it is worth noting that this module is not meant to be directly used as the root module and it is only in root modules we need to mark outputs as sensitive. We can still accept this since we have this for the mysql.

@6aKa
Copy link
Contributor Author

6aKa commented Aug 9, 2022

I catch error when try use module from terragrunt.

terraform {
  source = "tfr:///GoogleCloudPlatform/sql-db/google//modules/postgresql//.?version=11.0.0"
}
inputs = {
  name                               = "test-db"
  random_instance_name = true
  ...
}

Because terragrunt catch all output from terraform module.

@comment-bot-dev
Copy link

@6aKa
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit ad6f427 into terraform-google-modules:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants