Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for create_bucket argument. #80

Closed
zcherry17 opened this issue Jun 29, 2022 · 2 comments · Fixed by #147
Closed

Support for create_bucket argument. #80

zcherry17 opened this issue Jun 29, 2022 · 2 comments · Fixed by #147
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work

Comments

@zcherry17
Copy link

zcherry17 commented Jun 29, 2022

TL;DR

The event-function module has a create_bucket input argument that should also be supported by this module.
The inclusion of this input argument permits the use case of using a bucket that already exists for the storage of function deployment sources when create_bucket is false and bucket_name points to an existing bucket.

Terraform Resources

https://registry.terraform.io/modules/terraform-google-modules/event-function/google/latest?tab=inputs

Detailed design

In main.tf:

module "main" {
    ...
    create_bucket = var.function_create_bucket
    ...
}

In variables.tf:

variable "function_create_bucket" {
    type = bool
    default = true
    description = "Whether to create a new bucket or use an existing one. If false, `bucket_name` should reference the name of the alternate bucket to use."
}

Additional information

I am more than happy to create a PR for this, and I think this should be supported since finer control is always nice, especially since that finer control is already supported by the underlying event functions module this module makes use of.

@zcherry17 zcherry17 added the enhancement New feature or request label Jun 29, 2022
@bharathkkb
Copy link
Member

Happy to review a PR for this!

@bharathkkb bharathkkb added good first issue Good for newcomers triaged Scoped and ready for work P3 medium priority issues labels Aug 25, 2022
@DarkWanderer
Copy link
Contributor

Does something like #147 work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants