Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support deletion of Cloud Asset Inventory feeds not in use in organization #198

Merged
merged 15 commits into from
May 7, 2024
Merged

feat: support deletion of Cloud Asset Inventory feeds not in use in organization #198

merged 15 commits into from
May 7, 2024

Conversation

renato-rudnicki
Copy link
Contributor

@renato-rudnicki renato-rudnicki commented Apr 12, 2024 •
edited
Loading

This PR supports the deletion of Cloud Asset Inventory feeds not in use in organization that match a given pattern

@renato-rudnicki renato-rudnicki requested a review from a team as a code owner April 12, 2024 21:24
@renato-rudnicki renato-rudnicki changed the title feat: support deletion of Cloud Asset Inventory feeds not in use in organization #183 feat: support deletion of Cloud Asset Inventory feeds not in use in organization #183 Apr 12, 2024
@renato-rudnicki renato-rudnicki changed the title feat: support deletion of Cloud Asset Inventory feeds not in use in organization #183 feat: support deletion of Cloud Asset Inventory feeds not in use in organization Apr 12, 2024
bharathkkb
bharathkkb approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comment about rebasing on Daniels PR to share some of the code

modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
@daniel-cit
Copy link
Contributor

@bharathkkb @apeabody Build is Green 🟢

@apeabody apeabody merged commit bd8f8ad into terraform-google-modules:master May 7, 2024
5 checks passed
@release-please release-please bot mentioned this pull request May 7, 2024
Merged
@apeabody apeabody mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renato-rudnicki @daniel-cit @bharathkkb @apeabody