Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GO1.21)!: support deletion of Tag Keys not in use in organizations in the clean up module #175

Merged
merged 14 commits into from
Dec 27, 2023
Merged

feat(GO1.21)!: support deletion of Tag Keys not in use in organizations in the clean up module #175

merged 14 commits into from
Dec 27, 2023

Conversation

daniel-cit
Copy link
Contributor

This pull request adds support for the deletion of Tag Keys not in use in organizations in the clean up module.
This PR also bumps the clean up Cloud Function runtime to golang 1.21

@daniel-cit daniel-cit requested a review from a team as a code owner December 19, 2023 21:21
@daniel-cit daniel-cit marked this pull request as draft December 22, 2023 14:48
@daniel-cit daniel-cit marked this pull request as ready for review December 26, 2023 20:35
@apeabody apeabody self-assigned this Dec 27, 2023
@apeabody apeabody mentioned this pull request Dec 27, 2023
Merged
apeabody
apeabody requested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit! Made a few error message suggestions.

modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/main.tf Show resolved Hide resolved
modules/project_cleanup/variables.tf Outdated Show resolved Hide resolved
@apeabody apeabody changed the title feat: support deletion of Tag Keys not in use in organizations in the clean up module feat!: support deletion of Tag Keys not in use in organizations in the clean up module Dec 27, 2023
@daniel-cit daniel-cit requested a review from apeabody December 27, 2023 23:07
apeabody
apeabody approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit - LGTM!

@apeabody apeabody changed the title feat!: support deletion of Tag Keys not in use in organizations in the clean up module feat(GO1.21)!: support deletion of Tag Keys not in use in organizations in the clean up module Dec 27, 2023
@apeabody apeabody merged commit 6cc42cd into terraform-google-modules:master Dec 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-cit @apeabody