Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include Ingress Settings variable #129

Merged
merged 3 commits into from
Jun 12, 2023
Merged

feat: include Ingress Settings variable #129

merged 3 commits into from
Jun 12, 2023

Conversation

alexrohv
Copy link
Contributor

@alexrohv alexrohv commented Jun 5, 2023

No description provided.

@alexrohv alexrohv requested a review from a team as a code owner June 5, 2023 18:59
@alexrohv
Copy link
Contributor Author

alexrohv commented Jun 5, 2023

@apeabody Would we be able to get this PR and #120 in the same release?

@apeabody
Copy link
Contributor

apeabody commented Jun 9, 2023

/gcbrun

apeabody
apeabody requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alexrohv - Question below:

variables.tf Outdated Show resolved Hide resolved
@alexrohv
Copy link
Contributor Author

@apeabody No problem. Updated default to null.

@apeabody
Copy link
Contributor

/gcbrun

apeabody
apeabody approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alexrohv!

@apeabody apeabody merged commit a68339d into terraform-google-modules:master Jun 12, 2023
@release-please release-please bot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrohv @apeabody