-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support optional tag binding #885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. My comments center around the lack of usage of google_tags_tag_key
in the module? AFAIK, the key and the value are paired together for the binding and we should give the user the ability to create both. What do you think?
My reasoning for this was the common use case seems to be that keys (and values) are defined at a higher level (org/folder) and only binding is performed at the project during creation time. There could be usecases where maybe project scoped tags are created but I am thinking we should recommend use the tags module for that. This would be similar to how we only allow attaching to a shared VPC via PF while requiring network module for full create functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions - saw the existing comment one why this doesn't need to be a breaking change.
Co-authored-by: Andrew Peabody <[email protected]>
fixes #884