Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make subnet_flow_logs and subnet_private_access into string variables #9

Closed
ocervell opened this issue Sep 17, 2018 · 5 comments
Closed

Make subnet_flow_logs and subnet_private_access into string variables #9

ocervell opened this issue Sep 17, 2018 · 5 comments

Comments

@ocervell
Copy link
Contributor

No description provided.

@morgante
Copy link
Contributor

Terraform recommends against having boolean input variables, instead using strings for consistency: https://www.terraform.io/docs/configuration/variables.html#booleans

@andreyk-code
Copy link
Contributor

andreyk-code commented Sep 24, 2018 •
edited
Loading

Even though "subnet_flow_logs and "subnet_private_access" technically aren't input variables (the subnets list is the input variable), should we convert them into strings for consistency with "shared_vpc_host" expecting a string?

@morgante
Copy link
Contributor

Yes, I think we should. Renaming this accordingly.

@morgante morgante changed the title Make shared_vpc_host a boolean var Make subnet_flow_logs and subnet_private_access into string variables Sep 24, 2018
@morgante morgante mentioned this issue Sep 24, 2018
Closed
@andreyk-code
Copy link
Contributor

PR submitted with fix: #13

@andreyk-code
Copy link
Contributor

Closing as fixed with merge of PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morgante @ocervell @andreyk-code