feat: Allow specifying HTTP and HTTPS port. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miromichalicka
changed the title
|
@miromichalicka thx for the PR. Can u plz follow this guide to fix lint issues. |
|
Hi @imrannayer, thank you for the review. I run and committed the output of |
|
Oh I got it. You need to make changes in template before running make build. You dont need to make changes directly in the code. |
|
Ok, should be done, let's see if there are any other issues. Thanks for your help. |
|
/gcbrun |
imrannayer
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/S load balancer supports HTTP/S on custom ports. This PR allows specifying ports - as per documentation exactly one port from 1-65535.