feat: Set edge_security_policy optional and add session_affinity in variables #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-awmalik
reviewed
May 23, 2023
| @@ -85,65 +85,65 @@ variable "backends" { | |||
| description = "Map backend indices to list of backend maps." | |||
| type = map(object({ | |||
| {% if not serverless %}{# not necessary for serverless as default port_name=http, protocol=HTTP #} | |||
There was a problem hiding this comment.
If the fields are all optional now, do we need this template check? Does it matter if this var exists in all modules generated for this template?
There was a problem hiding this comment.
Although fields are optional now but I am worried people will provide value and get error. In order to avoid it I just wanted to remove it from Serverless NEG. Since these are all optional people can use main module to deploy serverless NEG.
There was a problem hiding this comment.
That's fair. I would suggest tracking that as an issue, if not already present.
g-awmalik
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #330
fix #331
fix #332
fix #323
fix #324