Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial release #4

Merged
merged 21 commits into from
Sep 12, 2018
Merged

Initial release #4

merged 21 commits into from
Sep 12, 2018

Conversation

lilithmooncohen
Copy link
Contributor

Resubmitting from terraform-google-kubernetes-engine/initial-release branch.

@lilithmooncohen
Copy link
Contributor Author

Previous comments can be seen on #1

@lilithmooncohen
Copy link
Contributor Author

All tests passing for both regional and zonal clusters

➜  make test_integration

Creating main.tf file
Creating outputs.tf file
Tests to execute: 33
 ✓ Ensure that Terraform configures the dirs and download the plugins
 ✓ Ensure that Terraform updates the plugins
 ✓ Terraform plan, ensure connection and creation of resources
 ✓ Terraform apply
 ✓ Terraform plan enable network policy
 ✓ Terraform apply
 ✓ Test the api is activated
 ✓ Test the cluster is in running status
 ✓ Test the cluster has the expected initial cluster version
 ✓ Test the cluster is in the expected location
 ✓ Test the cluster is in the expected network
 ✓ Test the cluster is in the expected subnetwork
 ✓ Test the cluster has the expected secondary ip range for pods
 ✓ Test the cluster has the expected secondary ip range for services
 ✓ Test the cluster has the expected addon settings
 ✓ Test default pool has no initial node count
 ✓ Test default pool has not auto scaling enabled
 ✓ Test pool-01 is expected version
 ✓ Test pool-01 has auto scaling enabled
 ✓ Test pool-01 has expected min node count
 ✓ Test pool-01 has expected max node count
 ✓ Test pool-01 is expected machine type
 ✓ Test pool-01 has expected disk size
 ✓ Test pool-01 has expected labels
 ✓ Test pool-01 has expected network tags
 ✓ Test pool-01 has auto repair enabled
 ✓ Test pool-01 has auto upgrade disabled
 ✓ Test pool-01 has expected taints
 ✓ Test kube dns configmap created
 ✓ Test ip masq agent configmap created
 ✓ Test that the nginx example service is reachable
 ✓ Terraform plan, ensure no change
 ✓ Terraform destroy
 
 33 tests

 Creating main.tf file
Creating outputs.tf file
Tests to execute: 33
 ✓ Ensure that Terraform configures the dirs and download the plugins
 ✓ Ensure that Terraform updates the plugins
 ✓ Terraform plan, ensure connection and creation of resources
 ✓ Terraform apply
 ✓ Terraform plan enable network policy
 ✓ Terraform apply
 ✓ Test the api is activated
 ✓ Test the cluster is in running status
 ✓ Test the cluster has the expected initial cluster version
 ✓ Test the cluster is in the expected location
 ✓ Test the cluster is in the expected network
 ✓ Test the cluster is in the expected subnetwork
 ✓ Test the cluster has the expected secondary ip range for pods
 ✓ Test the cluster has the expected secondary ip range for services
 ✓ Test the cluster has the expected addon settings
 ✓ Test default pool has no initial node count
 ✓ Test default pool has not auto scaling enabled
 ✓ Test pool-01 is expected version
 ✓ Test pool-01 has auto scaling enabled
 ✓ Test pool-01 has expected min node count
 ✓ Test pool-01 has expected max node count
 ✓ Test pool-01 is expected machine type
 ✓ Test pool-01 has expected disk size
 ✓ Test pool-01 has expected labels
 ✓ Test pool-01 has expected network tags
 ✓ Test pool-01 has auto repair enabled
 ✓ Test pool-01 has auto upgrade disabled
 ✓ Test pool-01 has expected taints
 ✓ Test kube dns configmap created
 ✓ Test ip masq agent configmap created
 ✓ Test that the nginx example service is reachable
 ✓ Terraform plan, ensure no change
 ✓ Terraform destroy
 
 33 tests

variables.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

variable "kubernetes_version" {
description = "The Kubernetes version of the masters. If set to 'latest' it will pull latest available version in the selected region."
default = "1.10.6-gke.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanckoch Should this default to "latest" - we probably don't want to have to constantly update this default.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the node pool example, I get this error:

* module.gke.google_container_node_pool.zonal_pools: At column 12, line 1: list "var.zones" does not have any elements so cannot determine type. in:

${var.zones[0]}

Explicitly setting zones fixed it but we shouldn't require people to choose their zones.

examples/shared_vpc/main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has matured enough to be released. All outstanding issues have been moved to issues.

@morgante morgante merged commit de0851f into master Sep 12, 2018
@aaron-lane aaron-lane deleted the initial-release branch April 10, 2019 16:12
mmontan added a commit to mmontan/terraform-google-kubernetes-engine that referenced this pull request Sep 30, 2019
# This is the 1st commit message:

Initial definition of a Safer Cluster module.

# This is the commit message terraform-google-modules#2:

Add a sample for using the safer-cluster module.

# This is the commit message terraform-google-modules#3:

Add a test kitchen instance

# This is the commit message terraform-google-modules#4:

Formatting TF files.

# This is the commit message terraform-google-modules#5:

Add a test for the safer-cluster module

# This is the commit message terraform-google-modules#6:

Additional fixes
aaron-lane pushed a commit that referenced this pull request Nov 26, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants