-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial release #4
Conversation
Previous comments can be seen on #1 |
All tests passing for both regional and zonal clusters
|
|
||
variable "kubernetes_version" { | ||
description = "The Kubernetes version of the masters. If set to 'latest' it will pull latest available version in the selected region." | ||
default = "1.10.6-gke.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanckoch Should this default to "latest" - we probably don't want to have to constantly update this default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the node pool example, I get this error:
* module.gke.google_container_node_pool.zonal_pools: At column 12, line 1: list "var.zones" does not have any elements so cannot determine type. in:
${var.zones[0]}
Explicitly setting zones fixed it but we shouldn't require people to choose their zones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has matured enough to be released. All outstanding issues have been moved to issues.
# This is the 1st commit message: Initial definition of a Safer Cluster module. # This is the commit message terraform-google-modules#2: Add a sample for using the safer-cluster module. # This is the commit message terraform-google-modules#3: Add a test kitchen instance # This is the commit message terraform-google-modules#4: Formatting TF files. # This is the commit message terraform-google-modules#5: Add a test for the safer-cluster module # This is the commit message terraform-google-modules#6: Additional fixes
…odules/initial-release Initial release
…odules/master update
Resubmitting from terraform-google-kubernetes-engine/initial-release branch.