fix: ignore control plane network when private endpoint subnet is set #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `master_ipv4_cidr_block` to `null` when `private_endpoint_subnetwork` is set, as the two conflict. Fixes terraform-google-modules#2119
wyardley
force-pushed
the
wyardley/issues_2119/private_endpoint_subnetwork
branch
from
d20738b to
2426401
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
master_ipv4_cidr_blocktonullwhenprivate_endpoint_subnetworkis set, as the two conflict with an API level error being thrown:Error: googleapi: Error 400: When masterIpv4Cidr is set, privateEndpointSubnetwork must be unset.Fixes #2119
This would have the effect of silently ignoring the setting even when
master_ipv4_cidr_blockis explicitly set. A better fix might be to throw an error, but given that there's a baked in default and that terraform module validation can't look at the values of other variables, I don't think that would be trivial.