Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for additive_vpc_scope_dns_domain #1998

Merged

Conversation

DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from ericyz, gtsorbo and a team as code owners July 16, 2024 21:00
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @DrFaust92!

autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Contributor

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/beta-private-cluster/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/modules/beta-private-cluster/variables.tf
718d717
< 
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/beta-private-cluster-update-variant/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/modules/beta-private-cluster-update-variant/variables.tf
718d717
< 
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/beta-public-cluster/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/modules/beta-public-cluster/variables.tf
688d687
< 
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/beta-public-cluster-update-variant/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/modules/beta-public-cluster-update-variant/variables.tf
688d687
< 
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/modules/private-cluster/variables.tf
688d687
< 
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster-update-variant/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/modules/private-cluster-update-variant/variables.tf
688d687
< 
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/variables.tf /tmp/tmp.5DNcIIxdjr/workspace/variables.tf
658d657
< 
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

@DrFaust92 DrFaust92 requested a review from apeabody July 18, 2024 19:07
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Jul 18, 2024
@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

Verified this is present in TPG v5.29.0+ (beta cluster)

@apeabody apeabody merged commit b54b7ba into terraform-google-modules:master Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants