-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TPG>=5.33)!: add secret manager add-on config to beta modules #1977
feat(TPG>=5.33)!: add secret manager add-on config to beta modules #1977
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
d55ef3c
to
69e259a
Compare
/gcbrun |
Hi @legal90 - Can you please rebase? |
69e259a
to
9e2b355
Compare
@apeabody Sure! Rebased now |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @legal90
Looks like this was added in v5.33.0, so please bump here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl
9e2b355
to
01e87e7
Compare
@apeabody Thank you, good point! I bumped the min version now. |
/gcbrun |
01e87e7
to
880f9d6
Compare
/gcbrun |
880f9d6
to
9b00414
Compare
/gcbrun |
Hi @legal90 - Can you please merge in changes from the base branch. Thanks! |
9b00414
to
5de7d85
Compare
@apeabody Sure! Rebased the branch now. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @legal90!
Hi @legal90 - Can you please rebase, I'm not able to update your PRs. Once it is current, and the checks are green, it's ready to merge. |
Co-authored-by: Jayanta Dutta <[email protected]>
Update all beta modules. "make build" Co-authored-by: Jayanta Dutta <[email protected]>
"secret_manager_config" argument was added in google provider v5.33.0 hashicorp/terraform-provider-google-beta#7448
5de7d85
to
afe1930
Compare
/gcbrun |
This PR adds a new variable to all beta-* modules allowing to enable Secret Manager add-on for GKE: