Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds local_nvme_ssd_block_config to beta-public-cluster #1912

Merged
merged 24 commits into from
Apr 12, 2024

Conversation

fl0-m
Copy link
Contributor

@fl0-m fl0-m commented Mar 23, 2024

No description provided.

@fl0-m fl0-m requested review from ericyz, gtsorbo and a team as code owners March 23, 2024 09:26
Copy link

google-cla bot commented Mar 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fl0-m
Copy link
Contributor Author

fl0-m commented Mar 23, 2024

@gtsorbo , @ericyz , @Jberlinsky would you please take a look ?

@apeabody
Copy link
Contributor

/gcbrun

@fl0-m
Copy link
Contributor Author

fl0-m commented Apr 3, 2024

@apeabody, would you be able to trigger CI again and give your approval please ?

@apeabody
Copy link
Contributor

apeabody commented Apr 3, 2024

/gcbrun

(re-trigger, quota)

@fl0-m
Copy link
Contributor Author

fl0-m commented Apr 4, 2024

had to rebase again,
@apeabody would you be able to trigger ci run again please ?

@gtsorbo , @ericyz , @Jberlinsky <ould you be able to approve please ?

@apeabody
Copy link
Contributor

apeabody commented Apr 4, 2024

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @florianMalbranque!

I've included a few notes below.

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/README.md Show resolved Hide resolved
autogen/main/README.md Outdated Show resolved Hide resolved
@fl0-m
Copy link
Contributor Author

fl0-m commented Apr 8, 2024

Thanks for your review @apeabody, it should be good now

@fl0-m fl0-m requested a review from apeabody April 8, 2024 11:45
@apeabody
Copy link
Contributor

apeabody commented Apr 8, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Apr 8, 2024

Hi @florianMalbranque - Looks like we need a quick make build, thanks!

@fl0-m
Copy link
Contributor Author

fl0-m commented Apr 8, 2024

Woops 🤦 , @apeabody make build executed and committed ✔️

@apeabody
Copy link
Contributor

apeabody commented Apr 8, 2024

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @florianMalbranque - A few final notes on the if beta_cluster blocks as ephemeral_storage_config is still beta.

autogen/main/README.md Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
@fl0-m
Copy link
Contributor Author

fl0-m commented Apr 12, 2024

Thanks again for your reviews @apeabody ! it should be good now, PTAL

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @florianMalbranque!

@apeabody apeabody merged commit f7c2ed9 into terraform-google-modules:master Apr 12, 2024
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…orm-google-modules#1912)

Co-authored-by: Mateusz Jędrzejewski <[email protected]>
Co-authored-by: Mateusz Jędrzejewski <[email protected]>
Co-authored-by: Amina Mansour <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants