Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make master_ipv4_cidr_block optional for autopilot #1902

Merged

Conversation

cloud-pharaoh
Copy link
Contributor

Fixing a bug with Autopilot Private cluster submodule

The default value provided in the module makes it not possible to create multiple clusters in the same VPC. This was likely added to cover for a provider bug that required master_ipv4_cidr_block to be set even for autopilot clusters but it was fixed days after the module additions for autopilot private were merged.

Note: In an Autopilot cluster, the --master-ipv4-cidr parameter is assigned a 
subnet within the 172.16.0.0/16 range by default. 
This range allows for various subnet sizes.
master_ipv4_cidr_block (Optional) - The IP range in CIDR notation to use for the hosted master network. 
This range will be used for assigning private IP addresses to the cluster master(s) and the ILB VIP. 
This range must not overlap with any other ranges in use within the cluster's network, 
and it must be a /28 subnet. See Private Cluster Limitations for more details. 
This field only applies to private clusters, when enable_private_nodes is true.
  • Module docs:
master_ipv4_cidr_block	(Beta) The IP range in CIDR notation to use for the hosted master network	string	"10.0.0.0/28"

@cloud-pharaoh cloud-pharaoh requested review from ericyz, gtsorbo and a team as code owners March 13, 2024 23:17
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cloud-pharaoh
Could you make the changes to autogen and run make build to generate the modules.

@cloud-pharaoh
Copy link
Contributor Author

Thanks @bharathkkb! Looks like I haven't contributed in so long. Things have changed a lot :)

@gtsorbo
Copy link
Contributor

gtsorbo commented Mar 14, 2024

/gcbrun

@cloud-pharaoh
Copy link
Contributor Author

@gtsorbo looks like an unrelated error and just needs to be rerun?

Step #37 - "verify simple-zonal-local":     jsonresult.go:42: Error parsing output, invalid json: E0314 17:30:29.310339     415 memcache.go:287] couldn't get resource list for metrics.k8s.io/v1beta1: the server is currently unable to handle the request

@gtsorbo gtsorbo merged commit af43bdd into terraform-google-modules:master Mar 15, 2024
4 checks passed
@cloud-pharaoh cloud-pharaoh deleted the am/fix-autopilot-private branch March 18, 2024 20:31
fl0-m pushed a commit to fl0-m/terraform-google-kubernetes-engine that referenced this pull request Mar 23, 2024
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants