-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update least privilege default service account #1844
feat!: Update least privilege default service account #1844
Conversation
This update follows changes from terraform-google-modules#1757 and reverts terraform-google-modules#1827. The role `roles/container.nodeServiceAccount` is deprecated now and it is replaced with new `roles/container.defaultNodeServiceAccount` role. Unfortunately this is not yet documented in Google docs. As the scope of the new role is smaller than the old one, this should be considered breaking change.
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
marked as breaking change per PR comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @gorge511!
Thanks for accepting my ideas and changes. |
how do we update to this from an older version? will it just delete and recreate this without any downtime? |
Can anyone confirm is there any downtime of this SA recreation for old clusters upgraded to v30? |
@gorge511 , could you share a reference about |
Hi @hSATAC this change is without any downtime. |
Hi @mmorejon, please see #1757 for a bigger discussion of why I did this PR. This is quite a new thing, but you can find the role easily with Unfortunately, this is so new that the public docs are not updated yet, but I got a thumbs up for using it from our Google TAM who consulted this with GKE developer team. |
…le-modules#1844) Co-authored-by: Jirka Korejtko <[email protected]>
This update follows changes from #1757 and reverts #1827.
The role
roles/container.nodeServiceAccount
is deprecated now and it is replaced with newroles/container.defaultNodeServiceAccount
role. Unfortunately this is not yet documented in Google docs.As the scope of the new role is smaller than the old one, this should be considered breaking change.