-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not ignore "mesh_id" label on "google_container_cluster" resource #1836
Merged
apeabody
merged 5 commits into
terraform-google-modules:master
from
legal90:fix-mesh-id-label-ignore
Jan 18, 2024
Merged
fix: Do not ignore "mesh_id" label on "google_container_cluster" resource #1836
apeabody
merged 5 commits into
terraform-google-modules:master
from
legal90:fix-mesh-id-label-ignore
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
approved these changes
Jan 8, 2024
/gcbrun |
1 similar comment
/gcbrun |
legal90
force-pushed
the
fix-mesh-id-label-ignore
branch
from
January 12, 2024 08:07
fe17efc
to
bed9276
Compare
/gcbrun |
/gcbrun |
/gcbrun |
apeabody
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @legal90!
Thanks for the review @ferrarimarco!
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1671
Relates to #1061
According to the documentation,
mesh_id
label is supposed to be set explicitly on the GKE cluster:terraform-google-kubernetes-engine/modules/asm/README.md
Lines 36 to 43 in d82c50c
However, right now this label is ignored by terraform, so it's not possible to set it using IaC.
This PR fixes that issue and removes
mesh_id
label from theignore_changes
list