Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alpha option for cluster creation #1796

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

prudnitskiy
Copy link
Contributor

This MR fixes cluster creation if enable_kubernetes_alpha is set to true. The problem is default pool created with auto_repair = true and auto_upgrade = true which prohibits cluster creation even if remove_default_node_pool set to true

@prudnitskiy prudnitskiy requested review from ericyz and a team as code owners November 7, 2023 16:34
Copy link

google-cla bot commented Nov 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@prudnitskiy prudnitskiy changed the title fix alpha option for cluster creation fix: alpha option for cluster creation Nov 13, 2023
@apeabody
Copy link
Contributor

apeabody commented Jan 9, 2024

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @prudnitskiy

@apeabody apeabody merged commit 67b67f3 into terraform-google-modules:master Jan 9, 2024
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants