Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support for enabling image streaming at cluster level #1696

Conversation

lauraseidler
Copy link
Contributor

Could previously be set manually via console/gcloud - if this was enabled, enable_gcfs must be set to true with this update, otherwise image streaming will be disabled.

Fixes #1360

Could previously be set manually via console/`gcloud` - if this was
enabled, `enable_gcfs` must be set to `true` with this update, otherwise
image streaming will be disabled.

Fixes terraform-google-modules#1360
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 21, 2023
@apeabody apeabody removed the Stale label Sep 21, 2023
@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @lauraseidler!

Good call on the breaking change ! flag.

@apeabody apeabody merged commit dbb57a2 into terraform-google-modules:master Sep 27, 2023
4 checks passed
@lauraseidler lauraseidler deleted the feature/image-streaming-cluster-level branch September 27, 2023 12:51
@Jojoooo1
Copy link

Jojoooo1 commented Nov 7, 2023

Any reason it is not supported for private cluster ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beta-private-cluster-update-variant] Enable image streaming at cluster level
3 participants