Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add support for disk_size and disk_type for cluster_autoscaling. #1693

Merged
merged 3 commits into from
Jul 28, 2023
Merged

feat!: Add support for disk_size and disk_type for cluster_autoscaling. #1693

merged 3 commits into from
Jul 28, 2023

Conversation

cread
Copy link
Contributor

@cread cread commented Jul 17, 2023 •
edited
Loading

Closes #1588

@cread cread requested review from a team, Jberlinsky and ericyz as code owners July 17, 2023 21:37
@cread cread changed the title Add support for optionally specifying disk_size and disk_type for cluster_autoscaling feat: Add support for disk_size and disk_type for cluster_autoscaling. Jul 18, 2023
@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

bharathkkb
bharathkkb requested changes Jul 25, 2023
View reviewed changes
autogen/main/variables.tf.tmpl
@@ -243,6 +243,8 @@ variable "cluster_autoscaling" {
gpu_resources = list(object({ resource_type = string, minimum = number, maximum = number }))
auto_repair = bool
auto_upgrade = bool
disk_size = optional(number)
disk_type = optional(string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using optional, could you also update min TF version to >= 1.3

terraform-google-kubernetes-engine/autogen/main/versions.tf.tmpl

Line 21 in f077184

required_version = ">=0.13"

terraform-google-kubernetes-engine/autogen/safer-cluster/versions.tf.tmpl

Line 23 in f077184

required_version = ">=0.13"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@bharathkkb bharathkkb changed the title feat: Add support for disk_size and disk_type for cluster_autoscaling. feat!: Add support for disk_size and disk_type for cluster_autoscaling. Jul 26, 2023
@bharathkkb
Copy link
Member

/gcbrun

bharathkkb
bharathkkb approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bharathkkb bharathkkb merged commit fd233e5 into terraform-google-modules:master Jul 28, 2023
@release-please release-please bot mentioned this pull request Jul 28, 2023
Merged
@cread cread deleted the add-cluster-autoscaling-disk-support branch July 28, 2023 19:30
@cread
Copy link
Contributor Author

cread commented Aug 30, 2023

Any idea when 28.0.0 will be released?

@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@cread @bharathkkb
feat!: Add support for disk_size and disk_type for cluster_autoscalin…
dd32844 
…g. (terraform-google-modules#1693)

Co-authored-by: Bharath KKB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support disk_type in cluster_autoscaling (Node Auto-provisioning)
2 participants
@cread @bharathkkb