-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set max firewall name to 36 #1645
fix: set max firewall name to 36 #1645
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @NissesSenap
Looks like some of our tests may need updating
terraform-google-kubernetes-engine/test/integration/safer_cluster/safer_cluster_test.go
Lines 66 to 67 in d252579
gcloud.Runf(t, "compute firewall-rules --project %s describe gke-%s-intra-cluster-egress", projectId, clusterName[:25]) | |
gcloud.Runf(t, "compute firewall-rules --project %s describe gke-%s-webhooks", projectId, clusterName[:25]) |
This to be able to have longer and unique names. The firewall API supports 64 charters Solves terraform-google-modules#1527 Signed-off-by: Edvin Norling <[email protected]>
Signed-off-by: Edvin Norling <[email protected]>
a2b70dd
to
d5d2718
Compare
@bharathkkb I updated the tests as you pointed out |
/gcbrun |
Looks like 36 is OOB since the test cluster name is smaller but I think we can just skip truncating since it's a static size from example.
|
/gcbrun |
Signed-off-by: Edvin Norling <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
This, to be able to have longer and unique names.
The firewall API supports 63 charters
Solves #1527
https://cloud.google.com/compute/docs/reference/rest/v1/firewalls