Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: set release_channel and auto_upgrade, drop meshtelemetry #1618

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix!: set release_channel and auto_upgrade, drop meshtelemetry #1618

merged 1 commit into from
Apr 28, 2023

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Apr 26, 2023 •
edited
Loading

  • Set release_channel default to REGULAR for GKE behavior, REGULAR is already default for safe_cluster
  • Set auto_upgrade to force true when a release_channel other than UNSPECIFIED is used
  • CI prepare stage is silently failing (CI prepare stage can silently fail #1619) as meshtelemetry.googleapis.com is deprecated: SERVICE_CONFIG_NOT_FOUND_OR_PERMISSION_DENIED

Fixes: #1620

@apeabody apeabody marked this pull request as ready for review April 26, 2023 18:42
@apeabody apeabody requested review from a team, Jberlinsky and ericyz as code owners April 26, 2023 18:42
@apeabody apeabody mentioned this pull request Apr 26, 2023
Merged
@apeabody apeabody changed the title chore: meshtelemetry is deprecated fix!: set release_channel REGULAR, drop meshtelemetry Apr 26, 2023
@apeabody apeabody changed the title fix!: set release_channel REGULAR, drop meshtelemetry fix!: update auto_upgrade and release_channel, drop meshtelemetry Apr 26, 2023
@apeabody apeabody changed the title fix!: update auto_upgrade and release_channel, drop meshtelemetry fix!: set release_channel and auto_upgrade, drop meshtelemetry Apr 26, 2023
bharathkkb
bharathkkb approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the upgrade guide too!

@apeabody apeabody merged commit 3c8dd3a into master Apr 28, 2023
@apeabody apeabody deleted the apeabody-patch-2 branch April 28, 2023 02:58
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody
fix!: set release_channel and auto_upgrade, drop meshtelemetry (terra…
97cc0fa 
…form-google-modules#1618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@g-awmalik g-awmalik Awaiting requested review from g-awmalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GKE Cluster Created with Incorrect Release Channel
2 participants
@apeabody @bharathkkb