Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blue/green upgrade strategy settings #1551

Merged
merged 10 commits into from
Apr 13, 2023
Merged

feat: add blue/green upgrade strategy settings #1551

merged 10 commits into from
Apr 13, 2023

Conversation

ProgEsteves
Copy link
Contributor

@ProgEsteves ProgEsteves commented Jan 31, 2023 •
edited
Loading

TL;DR

Add support to GKE blue/green upgrade strategy.
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#nested_upgrade_settings

Node pool upgrade strategies.
https://cloud.google.com/kubernetes-engine/docs/concepts/node-pool-upgrade-strategies

To attend.
Support for node pool upgrade strategy #1472

Terraform Resources

No response

Detailed design

No response

Additional information

No breaking changes has expected.
Old node_pools still work using SURGE strategy as well.

New variables

Name Description Default Requirement
strategy The upgrade stragey to be used for upgrading the nodes. Valid values of state are: SURGE or BLUE_GREEN "SURGE" Optional
node_pool_soak_duration Time needed after draining the entire blue pool. After this period, the blue pool will be cleaned up. By default, it is set to one hour (3600 seconds). The maximum length of the soak time is 7 days (604,800 seconds). "3600s" Optional
batch_soak_duration Soak time after each batch gets drained, with the default being zero seconds. "0s" Optional
batch_node_count Absolute number of nodes to drain in a batch. If it is set to zero, this phase will be skipped. Cannot be used together with batch_percentage 1 Optional
batch_percentage Percentage of nodes to drain in a batch. Must be in the range of [0.0, 1.0]. If it is set to zero, this phase will be skipped. Cannot be used together with batch_node_count null Optional

@ProgEsteves ProgEsteves requested review from a team, Jberlinsky and ericyz as code owners January 31, 2023 13:44
@google-cla
Copy link

google-cla bot commented Jan 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch from 944d4ed to 327715e Compare January 31, 2023 13:45
@ProgEsteves ProgEsteves mentioned this pull request Jan 31, 2023
Closed
@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch 8 times, most recently from 3fcdd45 to d673390 Compare February 5, 2023 20:13
@comment-bot-dev
Copy link

@ProgEsteves
Thanks for the PR! 🚀
✅ Lint checks have passed.

@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch 6 times, most recently from b359266 to c8cd668 Compare February 11, 2023 23:15
@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch 3 times, most recently from 78e39ad to f397f5f Compare February 17, 2023 14:57
bharathkkb
bharathkkb requested changes Feb 23, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ProgEsteves

modules/beta-private-cluster/cluster.tf Outdated Show resolved Hide resolved
modules/beta-private-cluster/variables.tf Outdated Show resolved Hide resolved
@bharathkkb
Copy link
Member

/gcbrun

@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch 4 times, most recently from 3b55f23 to 8df4d1a Compare February 24, 2023 13:08
@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch 2 times, most recently from 5d5e3c2 to 6799ff4 Compare March 7, 2023 22:50
@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch from 6799ff4 to 1091de2 Compare March 14, 2023 10:54
@MatthewAncientGaming
Copy link

+1 we're looking for this feature to be merged 🚀

@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch from 1091de2 to 1d8d7f2 Compare March 26, 2023 14:33
@awx-fuyuanchu
Copy link

+1 we're looking for this feature to be merged 🚀

@zeemy23
Copy link

zeemy23 commented Mar 28, 2023

cc @Jberlinsky @ericyz

@ProgEsteves ProgEsteves force-pushed the enable_blue_green_upgrade_strategy branch from e02f566 to a9d510c Compare March 31, 2023 12:26
@wintergren
Copy link

+1 also waiting for this feature to be merged! 🚀

@bogaertg
Copy link
Contributor

bogaertg commented Apr 7, 2023

+1 🚀

@NeckBeardPrince
Copy link

Looking forward to this 👍

@bharathkkb
Copy link
Member

/gcbrun

@awx-fuyuanchu
Copy link

awx-fuyuanchu commented Apr 13, 2023 •
edited
Loading

Cool. all checks have passed

@bharathkkb
Copy link
Member

@ProgEsteves sorry for the delay!

@bharathkkb bharathkkb merged commit db51271 into terraform-google-modules:master Apr 13, 2023
@release-please release-please bot mentioned this pull request Apr 13, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@ProgEsteves
feat: add blue/green upgrade strategy settings (terraform-google-modu…
18ee8e1 
…les#1551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ProgEsteves @comment-bot-dev @bharathkkb @zeemy23 @MatthewAncientGaming @awx-fuyuanchu @wintergren @bogaertg @NeckBeardPrince