Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default node pools and manage them explicitly #15

Closed
pratikmallya opened this issue Sep 26, 2018 · 6 comments
Closed

Remove default node pools and manage them explicitly #15

pratikmallya opened this issue Sep 26, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@pratikmallya
Copy link
Contributor

The default node pools cause trouble with managing the cluster. It seems like a better architecture to manage the node pools explicitly. Does it make sense to use the remove_default_node_pool parameter for the google_container_cluster and add just manage the node pools explicitly?

ref: hashicorp/terraform-provider-google#475 (comment)

@morgante
Copy link
Contributor

We definitely encourage explicitly managing the node pools, as shown in the examples: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/examples/node_pool

Regarding the remove_default_node_pool parameter, I believe we ran into some trouble with bootstrapping using it. @ryanckoch can share more. The approach we have today is, I believe, to create a default node pool with 0 nodes.

@pratikmallya
Copy link
Contributor Author

Oh, would love to hear about what the issues were with using that parameter @ryanckoch :)

@AdrienWalkowiak
Copy link

I would love to see this fixed too!

@miles-
Copy link

miles- commented Dec 4, 2018

I'd also like to help get this fixed - what was the issue with the remove_default_node_pool parameter? @ryanckoch

@morgante
Copy link
Contributor

morgante commented Dec 5, 2018

@ryanckoch Can you chime in here?

@aaron-lane
Copy link
Contributor

Fixed by #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants