feat!: expose global master access in GA modules #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyz
force-pushed
the
fix/global-master-access
branch
from
a4a72ec to
1c43fc7
Compare
ericyz
changed the title
bharathkkb
reviewed
Oct 21, 2022
ericyz
force-pushed
the
fix/global-master-access
branch
from
0f3659d to
0e18e7f
Compare
|
Updated. @bharathkkb - please review |
ericyz
force-pushed
the
fix/global-master-access
branch
2 times, most recently
from
a2f36c6 to
c4e37a8
Compare
|
@bharathkkb - I think the test case was failed due to other reasons. Could you please help to verify and let me know any chance required for this MR |
|
Hi @bharathkkb , any chance to review and provide feedback? This MR is on the critical path on the project. (rebased to master) |
bharathkkb
approved these changes
Nov 16, 2022
bharathkkb
requested changes
Nov 16, 2022
There was a problem hiding this comment.
@ericyz Sorry for the delay, CI had some issues. You could remove that unrelated change from the PR and this should be good to go
…lock (terraform-google-modules#1457) * Add support for https_proxy parameter for the config_sync.git block * Changes post make buid and make docker_generate_docs runs
ericyz
force-pushed
the
fix/global-master-access
branch
from
e2a193d to
be0906c
Compare
bharathkkb
changed the title
|
@ericyz |
bharathkkb
approved these changes
Nov 17, 2022
|
Does this change Global master access default to True |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…dules#1421) * feat: Add support for https_proxy parameter for the config_sync.git block (terraform-google-modules#1457) * Add support for https_proxy parameter for the config_sync.git block * Changes post make buid and make docker_generate_docs runs * switch default to true as next release is breaking * fmt Co-authored-by: Catalin Muresan <[email protected]> Co-authored-by: bharathkkb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Global Master Access is already in GA TF provider.
This change will expose private_cluster_config.master_global_access_config in available GA modules