-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gke_backup_agent_config
arg
#1316
Merged
bharathkkb
merged 2 commits into
terraform-google-modules:master
from
DrFaust92:gke-backup
Jul 19, 2022
Merged
feat: add gke_backup_agent_config
arg
#1316
bharathkkb
merged 2 commits into
terraform-google-modules:master
from
DrFaust92:gke-backup
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrFaust92
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
July 10, 2022 19:36
DrFaust92
changed the title
add
feat: add Jul 10, 2022
gke_backup_agent_config
arggke_backup_agent_config
arg
bharathkkb
requested changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @DrFaust92
@DrFaust92 |
bharathkkb
approved these changes
Jul 19, 2022
Is it expected that it takes a really long time to apply the change (like 20-30m), even though the backup config is already disabled? Similar behavior to mine, btw (#1332) ~ resource "google_container_cluster" "primary" {
id = "projects/xxxx"
name = "xx"
# (28 unchanged attributes hidden)
~ addons_config {
+ gke_backup_agent_config {
+ enabled = false
}
# (9 unchanged blocks hidden)
}
# (20 unchanged blocks hidden)
} |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
* add gke_backup_agent_config arg * CR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1257