Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: source node pools' auto_upgrade configuration from the GKE default config #1293

Merged
merged 1 commit into from
Jun 21, 2022
Merged

feat: source node pools' auto_upgrade configuration from the GKE default config #1293

merged 1 commit into from
Jun 21, 2022

Conversation

MrwanBaghdad
Copy link
Contributor

Allows the module to use the default_auto_upgrade to infer if the auto_upgrade is enabled for the node pool. This is in line with how the auto_upgrade config is calculated in the node_pool resource 

  management {
    auto_repair  = lookup(each.value, "auto_repair", true)
    auto_upgrade = lookup(each.value, "auto_upgrade", local.default_auto_upgrade)
  }

@MrwanBaghdad MrwanBaghdad requested review from a team, Jberlinsky and bharathkkb as code owners June 15, 2022 15:21
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@MrwanBaghdad
Copy link
Contributor Author

@bharathkkb Can you please take a look?

bharathkkb
bharathkkb approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MrwanBaghdad

@bharathkkb bharathkkb merged commit c7c9f44 into terraform-google-modules:master Jun 21, 2022
@release-please release-please bot mentioned this pull request Jun 21, 2022
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@MrwanBaghdad
fix: source node pools' auto_upgrade configuration from the GKE clust…
2d28c0a 
…er (terraform-google-modules#1293)

default_auto_upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrwanBaghdad @comment-bot-dev @bharathkkb