Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Autopilot cluster modules README usage blocks #1271

Closed
jacks-reid opened this issue May 26, 2022 · 2 comments
Closed

Update Autopilot cluster modules README usage blocks #1271

jacks-reid opened this issue May 26, 2022 · 2 comments
Labels
bug Something isn't working Stale

Comments

@jacks-reid
Copy link

TL;DR

The README usage blocks for both the beta-autopilot-private-cluster and beta-autopilot-public-cluster modules have outdated inputs. The filestore_csi_driver and enable_autopilot arguments shown are not found within variables.tf.

In addition, I believe the enable_vertical_pod_autoscaling variable should be enabled in the usage block otherwise the Autopilot cluster will error at creation time with: Error 400: Autopilot clusters require vertical pod autoscaler to be enabled., badRequest.

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

module "gke" {
  source                          = "../../modules/beta-autopilot-public-cluster/"
  project_id                      = var.project_id
  name                            = "${local.cluster_type}-cluster"
  regional                        = true
  region                          = var.region
  network                         = module.gcp-network.network_name
  subnetwork                      = local.subnet_names[index(module.gcp-network.subnets_names, local.subnet_name)]
  ip_range_pods                   = local.pods_range_name
  ip_range_services               = local.svc_range_name
  release_channel                 = "REGULAR"
  filestore_csi_driver            = false # delete me
  enable_autopilot                = true # delete me
  enable_vertical_pod_autoscaling = true # add me
}

Terraform Version

Terraform v1.2.1

Additional information

No response

@jacks-reid jacks-reid added the bug Something isn't working label May 26, 2022
@GusPrice
Copy link

I noticed this too, I think enable_autopilot is there for the eventual merge of the beta into main. I do think the module is also missing support for node service accounts, which are supposed to work in Autopilot according to:
hashicorp/terraform-provider-google#9505

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants